On 3/27/2020 6:44 AM, Herbert Xu wrote: > On Tue, Mar 17, 2020 at 01:08:18PM +0000, Iuliana Prodan wrote: >> >> This case can happen right now, also. I can't guarantee that all drivers >> send all requests via crypto-engine. > > I think this is something that we should address. I agree we should not have failed requests, _with_ MAY_BACKLOG, that pass through crypto-engine. All these requests must me executed. For this case I have a solution and I'll work on it. > If a driver > is going to use crypto_engine then really all requests should go > through that. IOW, we should have a one-to-one relationship between > engines and hardware. > This cannot happen right now. For non-crypto API requests (like split key or rng) I cannot pass them through crypto-engine which only supports aead, skcipher, hash and akcipher requests. So, I believe that if the first problem is solved (to have all crypto API requests, that have backlog flag executed - retry mechanism instead of reporting failure) the non-crypto API request doesn't have to be pass through crypto-engine - these can be handled by driver. Thanks, Iulia