On Sun, Mar 22, 2020 at 7:09 PM Masahiro Yamada <masahiroy@xxxxxxxxxx> wrote: > > arch/x86/Makefile tests instruction code by $(call as-instr, ...) > > Some of them are very old. > For example, the check for CONFIG_AS_CFI dates back to 2006. > > We raise GCC versions from time to time, and we clean old code away. > The same policy applied to binutils. > > The current minimal supported version of binutils is 2.21 > > This is new enough to recognize the instruction in most of > as-instr calls. I'm quite happy to see this series; a few weekends ago I was playing around with adding dwarf-5 support to the Linux kernel, and was looking at these noticing there was quite a bit of cruft. Unfortunately, I got detoured filing bugs against GNU as for dwarf-5 bugs, but the developers were very responsive and fixed them all. I should go find and dust off that patchset. In the meantime, I'll try to help review these patches. Thank you for sending them. > > > > Masahiro Yamada (7): > x86: remove unneeded defined(__ASSEMBLY__) check from asm/dwarf2.h > x86: remove always-defined CONFIG_AS_CFI > x86: remove always-defined CONFIG_AS_CFI_SIGNAL_FRAME > x86: remove always-defined CONFIG_AS_CFI_SECTIONS > x86: remove always-defined CONFIG_AS_SSSE3 > x86: remove always-defined CONFIG_AS_AVX > x86: add comments about the binutils version to support code in > as-instr > > arch/x86/Makefile | 21 +++------ > arch/x86/crypto/Makefile | 32 ++++++-------- > arch/x86/crypto/aesni-intel_avx-x86_64.S | 3 -- > arch/x86/crypto/aesni-intel_glue.c | 14 +----- > arch/x86/crypto/blake2s-core.S | 2 - > arch/x86/crypto/poly1305-x86_64-cryptogams.pl | 8 ---- > arch/x86/crypto/poly1305_glue.c | 6 +-- > arch/x86/crypto/sha1_ssse3_asm.S | 4 -- > arch/x86/crypto/sha1_ssse3_glue.c | 9 +--- > arch/x86/crypto/sha256-avx-asm.S | 3 -- > arch/x86/crypto/sha256_ssse3_glue.c | 8 +--- > arch/x86/crypto/sha512-avx-asm.S | 2 - > arch/x86/crypto/sha512_ssse3_glue.c | 7 +-- > arch/x86/include/asm/dwarf2.h | 43 ------------------- > arch/x86/include/asm/xor_avx.h | 9 ---- > lib/raid6/algos.c | 2 - > lib/raid6/recov_ssse3.c | 6 --- > lib/raid6/test/Makefile | 3 -- > 18 files changed, 26 insertions(+), 156 deletions(-) > > -- > 2.17.1 > > -- > You received this message because you are subscribed to the Google Groups "Clang Built Linux" group. > To unsubscribe from this group and stop receiving emails from it, send an email to clang-built-linux+unsubscribe@xxxxxxxxxxxxxxxx. > To view this discussion on the web visit https://groups.google.com/d/msgid/clang-built-linux/20200323020844.17064-1-masahiroy%40kernel.org. -- Thanks, ~Nick Desaulniers