On Mon, Mar 23, 2020 at 7:53 AM Jason A. Donenfeld <Jason@xxxxxxxxx> wrote: > > On Mon, Mar 23, 2020 at 12:36 AM Masahiro Yamada <masahiroy@xxxxxxxxxx> wrote: > > > > Hi Jason, > > > > On Mon, Mar 23, 2020 at 1:28 PM Jason A. Donenfeld <Jason@xxxxxxxxx> wrote: > > > > > > Hi again, > > > > > > I've consolidated your patches and rebased mine on top, and > > > incorporated your useful binutils comments. The result lives here: > > > > > > https://git.zx2c4.com/linux-dev/log/?h=jd/kconfig-assembler-support > > > > > > I can submit all of those to the list, if you want, or maybe you can > > > just pull them out of there, include them in your v2, and put them in > > > your tree for 5.7? However you want is fine with me. > > > > > > Your series does not work correctly. > > > > I will comment why later. > > Bummer, okay. Looking forward to learning what's up. Also, if some > parts of it are useful (like the resorting and organizing of > arch/x86/crypto/Makefile), feel free to cannibalize it, keeping what's > useful and discarding what's not. > Hi Jason, I have your patches on my radar. I have not checked your Kconfig changes are really working, especially I looked at [2] and comment on this. I would have expected your arch/x86/Kconfig.assembler file as arch/x86/crypto/Kconfig (source include needs to be adapted in arch/x86/Kconfig). What about a commit subject like "x86: crypto: Probe assembler options via Kconfig instead of makefile"? Not sure if the commit message needs some massage? Maybe this is all irrelevant when Masahiro has commented. Thanks. Regards, - Sedat - [1] https://git.kernel.org/pub/scm/linux/kernel/git/zx2c4/linux.git/log/?h=jd/kconfig-assembler-support [2] https://git.kernel.org/pub/scm/linux/kernel/git/zx2c4/linux.git/commit/?h=jd/kconfig-assembler-support&id=ac483ff6fb4c785cd0b10d9756b71696829cd117
