On Mon, Mar 16, 2020 at 11:16 PM Rayagonda Kokatanur <rayagonda.kokatanur@xxxxxxxxxxxx> wrote: > > Return error upon failure instead of using BUG_ON(). > BUG_ON() will crash the kernel. > > Signed-off-by: Rayagonda Kokatanur <rayagonda.kokatanur@xxxxxxxxxxxx> I don't think this patch is worth it, it has 2 problems: - These conversions are buggy. Upper layers assume that the calls will fall back to synchronous operation internally if they return NULL. - These assertions indicate a major programming error that should not be silently ignored. They need to be WARN_ON_ONCE() at a minimum, but only if the above issue is solved. These assertions are validating the raid implementation in raid5.c which has been correctly handling this path for several years. The risk of the code reorganization to "fix" this is higher than the benefit given zero reports of these actually triggering in production.
