On Tue, Feb 4, 2020 at 6:08 AM Horia Geanta <horia.geanta@xxxxxxx> wrote: > > On 1/27/2020 6:57 PM, Andrey Smirnov wrote: > > Be consistent with the rest of the codebase and use GFP_DMA when > > allocating memory for a CAAM JR descriptor. > > > Please use GFP_DMA32 instead. > Device is not limited to less than 32 bits of addressing > in any of its incarnations. > > s/GFP_DMA/GFP_DMA32 should be performed throughout caam driver. > (But of course, I wouldn't include this change in current patch series). > Hmm, I am triggering https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/mm/slub.c?h=v5.6-rc6#n1721 by using GFP_DMA32. AFAICT, GFP_DMA32 can't be used in SLUB/SLAB allocated memory: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/mm/internal.h?h=v5.6-rc6#n32 I'll stick with GFP_DMA for now, unless you have a different preference. Thanks, Andrey Smirnov
