On Tue, Feb 11, 2020 at 10:23 AM Horia Geanta <horia.geanta@xxxxxxx> wrote: > > On 1/27/2020 6:57 PM, Andrey Smirnov wrote: > > Use devm_kzalloc() to allocate JR data in order to make sure that it > > is initialized consistently every time. > > > The commit message is a bit vague. > > I assume this is needed in patch 4/9, which adds a new member (hwrng) > in caam_drv_private_jr structure. > > If so, it's probably better to have the change merged into patch 4/9. > Yes, it is specifically needed for 4/9, but it's generally a good practice to zero out allocated memory, so I made it a separate patch. Will fold it into 4/9, since that's what you prefer. Thanks, Andrey Smirnov