Re: [PATCH] hwrng: imx-rngc: improve dependencies

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2/5/2020 4:00 PM, Uwe Kleine-König wrote:
> The imx-rngc driver binds to devices that are compatible to
> "fsl,imx25-rngb". Grepping through the device tree sources suggests this
> only exists on i.MX25. So restrict dependencies to configs that have
The driver could also be used by some i.MX6 SoCs (SL, SLL),
that have a compatible rngb.

Actually i.MX6SL has a rngb node in the DT, but unfortunately it lacks
a compatible string.

I am planning to address this short term.

> this SoC enabled, but allow compile testing. For the latter additional
> dependencies for clk and readl/writel are necessary.
> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
> ---
>  drivers/char/hw_random/Kconfig | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/char/hw_random/Kconfig b/drivers/char/hw_random/Kconfig
> index 8486c29d8324..17fe954fccde 100644
> --- a/drivers/char/hw_random/Kconfig
> +++ b/drivers/char/hw_random/Kconfig
> @@ -244,7 +244,8 @@ config HW_RANDOM_MXC_RNGA
>  
>  config HW_RANDOM_IMX_RNGC
>  	tristate "Freescale i.MX RNGC Random Number Generator"
> -	depends on ARCH_MXC
> +	depends on HAS_IOMEM && HAVE_CLK
> +	depends on SOC_IMX25 || COMPILE_TEST
I guess SOC_IMX6SL and SOC_IMX6SLL will have to be added.
Does this sound good?

Thanks,
Horia




[Index of Archives]     [Kernel]     [Gnu Classpath]     [Gnu Crypto]     [DM Crypt]     [Netfilter]     [Bugtraq]

  Powered by Linux