Re: [PATCH] [RFC] crypto: ccree - fix retry handling in cc_send_sync_request()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jan 29, 2020 at 11:11 AM Gilad Ben-Yossef <gilad@xxxxxxxxxxxxx> wrote:
>
> On Tue, Jan 28, 2020 at 9:09 PM Geert Uytterhoeven
> <geert+renesas@xxxxxxxxx> wrote:
> >
> > If cc_queues_status() indicates that the queue is full,
> > cc_send_sync_request() should loop and retry.
> >
> > However, cc_queues_status() returns either 0 (for success), or -ENOSPC
> > (for queue full), while cc_send_sync_request() checks for real errors by
> > comparing with -EAGAIN.  Hence -ENOSPC is always considered a real
> > error, and the code never retries the operation.
> >
> > Fix this by just removing the check, as cc_queues_status() never returns
> > any other error value than -ENOSPC.
>

OK, it took me a minute but I now see what you mean... your patch does
the right thing.

Acked-by: Gilad Ben-Yossef <gilad@xxxxxxxxxxxxx>

Gilad



[Index of Archives]     [Kernel]     [Gnu Classpath]     [Gnu Crypto]     [DM Crypt]     [Netfilter]     [Bugtraq]

  Powered by Linux