On Mon, Jan 13, 2020 at 6:10 AM Horia Geanta <horia.geanta@xxxxxxx> wrote: > > On 1/8/2020 5:42 PM, Andrey Smirnov wrote: > > In order to follow recommendation in SP800-90C (section "9.4 The > > Oversampling-NRBG Construction") limit the output of "generate" JD > > submitted to CAAM. See > > https://lore.kernel.org/linux-crypto/VI1PR0402MB3485EF10976A4A69F90E5B0F98580@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx/ > > for more details. > > > > This change should make CAAM's hwrng driver good enough to have 999 > > quality rating. > > > [...] > > @@ -241,6 +241,7 @@ int caam_rng_init(struct device *ctrldev) > > ctx->rng.init = caam_init; > > ctx->rng.cleanup = caam_cleanup; > > ctx->rng.read = caam_read; > > + ctx->rng.quality = 999; > > > AFAICS the maximum value of hwrng.quality is 1024. > > Any reason why it's configured to be lower, now that CAAM RNG-based DRBG > is configured to reseed as requested by FIPS spec to behave as a TRNG? > Only my reading of the old version of corresponding documentation which listed this field as being per mil. Will fix in v7. Thanks, Andrey Smirnov
