Hi Horia, Thanks for review comment. Yes, rightly said. I will re-work and update. Regards Pankaj -----Original Message----- From: Horia Geanta <horia.geanta@xxxxxxx> Sent: Thursday, January 23, 2020 8:18 PM To: Pankaj Gupta <pankaj.gupta@xxxxxxx>; Aymen Sghaier <aymen.sghaier@xxxxxxx>; Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>; David S. Miller <davem@xxxxxxxxxxxxx>; linux-crypto@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx Cc: Arun Pathak <arun.pathak@xxxxxxx> Subject: Re: [PATCH] add support for TLS1.2 algorithms offload On 1/23/2020 1:22 PM, Pankaj Gupta wrote: > - aes-128-cbc-hmac-sha256 > - aes-256-cbc-hmac-sha256 > > Enabled the support of TLS1.1 algorithms offload > > - aes-128-cbc-hmac-sha1 > - aes-256-cbc-hmac-sha1 > Patch does not apply, since there's no specific tls support in upstream caam drivers. caam drivers register crypto algorithms to the crypto API, and ktls uses whatever it pleases: https://www.kernel.org/doc/html/latest/networking/tls-offload.html https://www.kernel.org/doc/html/latest/networking/tls.html Horia