Re: [PATCH] crypto: chacha20poly1305 - add back missing test vectors and test chunking

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Jason A. Donenfeld <Jason@xxxxxxxxx> wrote:
> When this was originally ported, the 12-byte nonce vectors were left out
> to keep things simple. I agree that we don't need nor want a library
> interface for 12-byte nonces. But these test vectors were specially
> crafted to look at issues in the underlying primitives and related
> interactions.  Therefore, we actually want to keep around all of the
> test vectors, and simply have a helper function to test them with.
> 
> Secondly, the sglist-based chunking code in the library interface is
> rather complicated, so this adds a developer-only test for ensuring that
> all the book keeping is correct, across a wide array of possibilities.
> 
> Signed-off-by: Jason A. Donenfeld <Jason@xxxxxxxxx>
> ---
> lib/crypto/chacha20poly1305-selftest.c | 1712 +++++++++++++++++++++++-
> 1 file changed, 1698 insertions(+), 14 deletions(-)

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt



[Index of Archives]     [Kernel]     [Gnu Classpath]     [Gnu Crypto]     [DM Crypt]     [Netfilter]     [Bugtraq]

  Powered by Linux