Hello Janakarajan Natarajan,
The patch edd303ff0e9e: "crypto: ccp - Add DOWNLOAD_FIRMWARE SEV
command" from May 25, 2018, leads to the following static checker
warning:
drivers/crypto/ccp/sev-dev.c:530 sev_update_firmware()
error: uninitialized symbol 'error'.
drivers/crypto/ccp/sev-dev.c
522 data = page_address(p);
523 memcpy(page_address(p) + data_size, firmware->data, firmware->size);
524
525 data->address = __psp_pa(page_address(p) + data_size);
526 data->len = firmware->size;
527
528 ret = sev_do_cmd(SEV_CMD_DOWNLOAD_FIRMWARE, data, &error);
^^^^^^
If "psp_dead" is already true then error isn't set.
529 if (ret)
530 dev_dbg(dev, "Failed to update SEV firmware: %#x\n", error);
531 else
532 dev_info(dev, "SEV firmware update successful\n");
533
534 __free_pages(p, order);
regards,
dan carpenter
