Hello Tudor Ambarus,
The patch 371731ec2179: "crypto: atmel-aes - Fix saving of IV for CTR
mode" from Dec 5, 2019, leads to the following static checker warning:
drivers/crypto/atmel-aes.c:1058 atmel_aes_ctr_transfer()
warn: right shifting more than type allows 16 vs 16
drivers/crypto/atmel-aes.c
1044 /* Check for transfer completion. */
1045 ctx->offset += dd->total;
1046 if (ctx->offset >= req->cryptlen)
1047 return atmel_aes_transfer_complete(dd);
1048
1049 /* Compute data length. */
1050 datalen = req->cryptlen - ctx->offset;
1051 ctx->blocks = DIV_ROUND_UP(datalen, AES_BLOCK_SIZE);
1052 ctr = be32_to_cpu(ctx->iv[3]);
1053
1054 /* Check 16bit counter overflow. */
1055 start = ctr & 0xffff;
1056 end = start + ctx->blocks - 1;
1057
1058 if (ctx->blocks >> 16 || end < start) {
^^^^^^^^^^^^^^^^^
Impossible condition.
1059 ctr |= 0xffff;
1060 datalen = AES_BLOCK_SIZE * (0x10000 - start);
1061 fragmented = true;
1062 }
regards,
dan carpenter
