On Tue, Dec 10, 2019 at 07:38:28PM -0800, Eric Biggers wrote: > On Sat, Dec 07, 2019 at 10:15:15PM +0800, Herbert Xu wrote: > > The function crypto_spawn_alg is racy because it drops the lock > > before shooting the dying algorithm. The algorithm could disappear > > altogether before we shoot it. > > > > This patch fixes it by moving the shooting into the locked section. > > > > Signed-off-by: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> > > Does this need Fixes and Cc stable tags? Fixes: 6bfd48096ff8 ("[CRYPTO] api: Added spawns") I don't think we want this to go through stable right away. Perhaps a few cycles down the track it could be pushed to stable. It's certainly not an urgent problem. Cheers, -- Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt