On Sun, Dec 08, 2019 at 01:42:52PM +0800, Herbert Xu wrote: > @@ -231,6 +225,8 @@ static struct shash_alg sha1_alg = { > .final = padlock_sha1_final, > .export = padlock_sha_export, > .import = padlock_sha_import, > + .init_tfm = padlock_cra_init, > + .exit_tfm = padlock_cra_exit, > .descsize = sizeof(struct padlock_sha_desc), > .statesize = sizeof(struct sha1_state), Nit: these should be renamed to padlock_sha_init_tfm() and padlock_sha_exit_tfm(). - Eric