On Fri, Dec 06, 2019 at 08:52:34PM -0800, Eric Biggers wrote: > > I think the general idea is much better. But it's not going to work as-is due > to all the templates that directly use crypto_init_spawn(), > crypto_init_shash_spawn(), and crypto_init_ahash_spawn(). I think they should > be converted to use new functions crypto_grab_cipher(), crypto_grab_shash(), and > crypto_grab_cipher(), so that everyone is consistently using crypto_grab_*(). While we should certainly convert them eventually, I don't think they are an immediate obstacle to this patch. We just need to make these legacy entry points grab an extra reference count which they can then drop as they do now. Cheers, -- Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
