* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * This automated bisection report was sent to you on the basis * * that you may be involved with the breaking commit it has * * found. No manual investigation has been done to verify it, * * and the root cause of the problem may be somewhere else. * * * * If you do send a fix, please include this trailer: * * Reported-by: "kernelci.org bot" <bot@xxxxxxxxxxxx> * * * * Hope this helps! * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * ardb/for-kernelci bisection: boot on rk3288-rock2-square Summary: Start: 16839329da69 enable extra tests by default Details: https://kernelci.org/boot/id/5de79104990bc03e5a960f0b Plain log: https://storage.kernelci.org//ardb/for-kernelci/v5.4-9340-g16839329da69/arm/multi_v7_defconfig+CONFIG_EFI=y+CONFIG_ARM_LPAE=y/gcc-8/lab-collabora/boot-rk3288-rock2-square.txt HTML log: https://storage.kernelci.org//ardb/for-kernelci/v5.4-9340-g16839329da69/arm/multi_v7_defconfig+CONFIG_EFI=y+CONFIG_ARM_LPAE=y/gcc-8/lab-collabora/boot-rk3288-rock2-square.html Result: 16839329da69 enable extra tests by default Checks: revert: PASS verify: PASS Parameters: Tree: ardb URL: git://git.kernel.org/pub/scm/linux/kernel/git/ardb/linux.git Branch: for-kernelci Target: rk3288-rock2-square CPU arch: arm Lab: lab-collabora Compiler: gcc-8 Config: multi_v7_defconfig+CONFIG_EFI=y+CONFIG_ARM_LPAE=y Test suite: boot Breaking commit found: ------------------------------------------------------------------------------- commit 16839329da69263e7360f3819bae01bcf4b220ec Author: Ard Biesheuvel <ardb@xxxxxxxxxx> Date: Tue Dec 3 12:29:31 2019 +0000 enable extra tests by default diff --git a/crypto/Kconfig b/crypto/Kconfig index 5575d48473bd..36af840aa820 100644 --- a/crypto/Kconfig +++ b/crypto/Kconfig @@ -140,7 +140,6 @@ if CRYPTO_MANAGER2 config CRYPTO_MANAGER_DISABLE_TESTS bool "Disable run-time self tests" - default y help Disable run-time self tests that normally take place at algorithm registration. @@ -148,6 +147,7 @@ config CRYPTO_MANAGER_DISABLE_TESTS config CRYPTO_MANAGER_EXTRA_TESTS bool "Enable extra run-time crypto self tests" depends on DEBUG_KERNEL && !CRYPTO_MANAGER_DISABLE_TESTS + default y help Enable extra run-time self tests of registered crypto algorithms, including randomized fuzz tests. diff --git a/crypto/testmgr.c b/crypto/testmgr.c index 88f33c0efb23..5df87bcf6c4d 100644 --- a/crypto/testmgr.c +++ b/crypto/testmgr.c @@ -40,7 +40,7 @@ static bool notests; module_param(notests, bool, 0644); MODULE_PARM_DESC(notests, "disable crypto self-tests"); -static bool panic_on_fail; +static bool panic_on_fail = true; module_param(panic_on_fail, bool, 0444); #ifdef CONFIG_CRYPTO_MANAGER_EXTRA_TESTS ------------------------------------------------------------------------------- Git bisection log: ------------------------------------------------------------------------------- git bisect start # good: [b94ae8ad9fe79da61231999f347f79645b909bda] Merge tag 'seccomp-v5.5-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/kees/linux git bisect good b94ae8ad9fe79da61231999f347f79645b909bda # bad: [16839329da69263e7360f3819bae01bcf4b220ec] enable extra tests by default git bisect bad 16839329da69263e7360f3819bae01bcf4b220ec # good: [25cbf24a7eec7c3dee4113b2e98b572e128009b7] crypto: aead - move crypto_aead_maxauthsize() to <crypto/aead.h> git bisect good 25cbf24a7eec7c3dee4113b2e98b572e128009b7 # good: [7b19c7a82950ed034645fa92adce29cd6163ed3e] crypto: testmgr - check skcipher min_keysize git bisect good 7b19c7a82950ed034645fa92adce29cd6163ed3e # good: [062752a354aaf03b46b86cba5fdaa2fd5c932860] crypto: testmgr - create struct aead_extra_tests_ctx git bisect good 062752a354aaf03b46b86cba5fdaa2fd5c932860 # good: [2cd56a00fff8584e342164c65e6b55da61f79c4a] crypto: testmgr - generate inauthentic AEAD test vectors git bisect good 2cd56a00fff8584e342164c65e6b55da61f79c4a # first bad commit: [16839329da69263e7360f3819bae01bcf4b220ec] enable extra tests by default -------------------------------------------------------------------------------
