On Sun, 1 Dec 2019 at 21:54, Eric Biggers <ebiggers@xxxxxxxxxx> wrote:
>
> This series makes some more improvements to the crypto self-tests, the
> largest of which is making the AEAD fuzz tests test inauthentic inputs,
> i.e. cases where decryption is expected to fail due to the (ciphertext,
> AAD) pair not being the correct result of an encryption with the key.
>
> It also updates the self-tests to test passing misaligned buffers to the
> various setkey() functions, and to check that skciphers have the same
> min_keysize as the corresponding generic implementation.
>
> I haven't seen any test failures from this on x86_64, arm64, or arm32.
> But as usual I haven't tested drivers for crypto accelerators.
>
> For this series to apply this cleanly, my other series
> "crypto: skcipher - simplifications due to {,a}blkcipher removal"
> needs to be applied first, due to a conflict in skcipher.h.
>
> This can also be retrieved from git at
> https://git.kernel.org/pub/scm/linux/kernel/git/ebiggers/linux.git
> tag "crypto-self-tests_2019-12-01".
>
> Eric Biggers (7):
> crypto: aead - move crypto_aead_maxauthsize() to <crypto/aead.h>
> crypto: skcipher - add crypto_skcipher_min_keysize()
> crypto: testmgr - don't try to decrypt uninitialized buffers
> crypto: testmgr - check skcipher min_keysize
> crypto: testmgr - test setting misaligned keys
> crypto: testmgr - create struct aead_extra_tests_ctx
> crypto: testmgr - generate inauthentic AEAD test vectors
>
I've dropped this into kernelci again, let's see if anything turns out
to be broken.
For this series,
Acked-by: Ard Biesheuvel <ardb@xxxxxxxxxx>
> crypto/testmgr.c | 574 +++++++++++++++++++++++++--------
> crypto/testmgr.h | 14 +-
> include/crypto/aead.h | 10 +
> include/crypto/internal/aead.h | 10 -
> include/crypto/skcipher.h | 6 +
> 5 files changed, 461 insertions(+), 153 deletions(-)
>
> --
> 2.24.0
>
