Re: [PATCH 0/2] crypto: api - remove crypto_tfm::crt_u

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 2 Dec 2019 at 21:42, Eric Biggers <ebiggers@xxxxxxxxxx> wrote:
>
> This series removes the per-algorithm-type union from struct crypto_tfm
> now that its only remaining users are the "compress" and "cipher"
> algorithm types, and it's not really needed for them.
>
> This shrinks every crypto transform for every algorithm by 28 bytes on
> 64-bit platforms (12 bytes on 32-bit), and also removes some code.
>
> Note that the new-style strongly-typed algorithms (i.e. everything other
> than "compress" and "cipher") don't need crt_u, since they embed struct
> crypto_tfm in a per-algorithm-type custom struct instead.
>
> Eric Biggers (2):
>   crypto: compress - remove crt_u.compress (struct compress_tfm)
>   crypto: cipher - remove crt_u.cipher (struct cipher_tfm)
>

Good riddance

Reviewed-by: Ard Biesheuvel <ardb@xxxxxxxxxx>

>  crypto/api.c           | 15 +------
>  crypto/cipher.c        | 92 +++++++++++++++++-------------------------
>  crypto/compress.c      | 31 ++++++--------
>  crypto/internal.h      |  3 --
>  include/linux/crypto.h | 91 ++++++-----------------------------------
>  5 files changed, 61 insertions(+), 171 deletions(-)
>
> --
> 2.24.0.393.g34dc348eaf-goog
>



[Index of Archives]     [Kernel]     [Gnu Classpath]     [Gnu Crypto]     [DM Crypt]     [Netfilter]     [Bugtraq]

  Powered by Linux