On Wed, Nov 27, 2019 at 10:19 AM Eric Biggers <ebiggers@xxxxxxxxxx> wrote:
>
> On Tue, Nov 19, 2019 at 12:13:53PM -0800, Sami Tolvanen wrote:
> > +static void __sha1_ce_transform(struct sha1_state *sst, u8 const *src,
> > + int blocks)
> > +{
> > + return sha1_ce_transform(container_of(sst, struct sha1_ce_state, sst),
> > + src, blocks);
> > +}
> > +
>
> 'return' isn't needed in functions that return void.
>
> Likewise everywhere else in this patch.
>
> Otherwise this patch looks fine.
Thanks for taking a look, Eric. I'll send out v4 with this fixed.
Sami
