On Fri, Nov 22, 2019 at 02:11:46PM +0000, Iuliana Prodan wrote: > > So, just to be clear, I shouldn't use crypto_async_request in driver code? > I see that this generic crypto request is used in multiple drivers. I understand that a number of drivers do this in order to share common code. However, this is definitely not the preferred way of handling this. Ideally such code should be abstracted into a higher layer such as crypto_engine so that the driver itself never references these internal types. > I can try sending _all_ requests to crypto engine and make some > performance measurements to see which solution is best. Thanks, -- Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
