On Wed, Nov 13, 2019 at 05:55:50PM +0800, YueHaibing wrote: > If CRYPTO_DEV_ATMEL_AUTHENC is m, CRYPTO_DEV_ATMEL_SHA is m, > but CRYPTO_DEV_ATMEL_AES is y, building will fail: > > drivers/crypto/atmel-aes.o: In function `atmel_aes_authenc_init_tfm': > atmel-aes.c:(.text+0x670): undefined reference to `atmel_sha_authenc_get_reqsize' > atmel-aes.c:(.text+0x67a): undefined reference to `atmel_sha_authenc_spawn' > drivers/crypto/atmel-aes.o: In function `atmel_aes_authenc_setkey': > atmel-aes.c:(.text+0x7e5): undefined reference to `atmel_sha_authenc_setkey' > > Make CRYPTO_DEV_ATMEL_AUTHENC depend on CRYPTO_DEV_ATMEL_AES, > and select CRYPTO_DEV_ATMEL_SHA and CRYPTO_AUTHENC for it under there. > > Reported-by: Hulk Robot <hulkci@xxxxxxxxxx> > Suggested-by: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> > Fixes: 89a82ef87e01 ("crypto: atmel-authenc - add support to...") > Signed-off-by: YueHaibing <yuehaibing@xxxxxxxxxx> > Reviewed-by: Tudor Ambarus <tudor.ambarus@xxxxxxxxxxxxx> > --- > v3: fix log typo > v2: make CRYPTO_DEV_ATMEL_AUTHENC depends on DEV_ATMEL_AES > --- > drivers/crypto/Kconfig | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt