On Thu, Nov 21, 2019 at 11:29:16AM +0100, Toke Høiland-Jørgensen wrote: > "Jason A. Donenfeld" <Jason@xxxxxxxxx> writes: > > > RFC Note: > > This is a RFC for folks who want to play with this early, because > > Herbert's cryptodev-2.6 tree hasn't yet made it into net-next. I'll > > repost this as a v1 (possibly with feedback incorporated) once the > > various trees are in the right place. This compiles on top of the > > Frankenzinc patchset from Ard, though it hasn't yet received suitable > > testing there for me to call it v1 just yet. Preliminary testing with > > the usual netns.sh test suite on x86 indicates it's at least mostly > > functional, but I'll be giving things further scrutiny in the days to > > come. > > Hi Jason > > Great to see this! Just a few small comments for now: > > > +/* > > + * Copyright (C) 2015-2019 Jason A. Donenfeld <Jason@xxxxxxxxx>. All Rights Reserved. > > + */ > > Could you please get rid of the "All Rights Reserved" (here, and > everywhere else)? All rights are *not* reserved: this is licensed under > the GPL. Besides, that phrase is in general dubious at best: > https://en.wikipedia.org/wiki/All_rights_reserved Don't take legal questions/advice on a developer mailing list :) This text is fine as-is, please consult your RedHat lawyers for why that is so. And if RedHat does have issues with this, have them please clean up the instances in the kernel where they have this same text before asking anyone else to do so. thanks, greg k-h
