On 11/5/2019 5:14 PM, Andrey Smirnov wrote: > @@ -589,8 +592,6 @@ static struct platform_driver caam_jr_driver = { > > static int __init jr_driver_init(void) > { > - spin_lock_init(&driver_data.jr_alloc_lock); > - INIT_LIST_HEAD(&driver_data.jr_list); > return platform_driver_register(&caam_jr_driver); > } > And with this change, jr_driver_{init,exit} could be replaced with module_platform_driver(caam_jr_driver); It's probably worth adding this here even if we later decide that moving away from platform driver for jr is the way to go. Horia