Am Dienstag, 19. November 2019, 11:06:02 CET schrieb Andy Lutomirski: Hi Andy, > On Sun, Nov 17, 2019 at 4:16 AM Stephan Müller <smueller@xxxxxxxxxx> wrote: > > Am Samstag, 16. November 2019, 17:39:40 CET schrieb Andy Lutomirski: > > > > Hi Andy, > > > > > > On Nov 16, 2019, at 1:40 AM, Stephan Müller <smueller@xxxxxxxxxx> > > > > wrote: > > > > > > > > The LRNG /proc interface provides the same files as the legacy > > > > /dev/random. These files behave identically. Yet, all files are > > > > documented at [1]. > > > > > > Why? > > > > I am not sure here: are you referring to the documentation? Or the one > > additional file? > > > > If it is the documentation, do you want me to add it to the patch > > description? I initially did not add it as these files were present and > > seemingly known what they provide. But I would add that documentation to > > the patch description if this is desired. > > Sorry, I should have been a lot more explicit. Why do you want to add > a new interface to read the RNG? What's wrong with the old one? There is nothing wrong at all. I actually want to be 100% API and ABI compliant with the existing random.c. Thus, the list of the sysctls are identical to the existing random.c with the same behavior (hence I skipped the documentation of these files). Yet, the wiring up of the interfaces to internal data structures and handlers is different than for the existing random.c. Also, the reason why I created a separate lrng_proc.c (and lrng_interface.c) is to allow a possible merger of this similar code with the existing random.c. The only question that needs to be solved is to find a common way to invoke the random.c internal logic and the LRNG internal logic with these interfaces. > > I think your patch description should explain the purpose of the patch. Ok, I can surely add a description for each file to the patch description. Ciao Stephan
