On 11/09/2019 07:09 PM, Ard Biesheuvel wrote: > @@ -1875,7 +1858,7 @@ static int atmel_aes_xts_start(struct atmel_aes_dev *dd) > if (err) > return atmel_aes_complete(dd, err); > > - /* Compute the tweak value from req->info with ecb(aes). */ > + /* Compute the tweak value from req->iv with ecb(aes). */ > flags = dd->flags; > dd->flags &= ~AES_FLAGS_MODE_MASK; > dd->flags |= (AES_FLAGS_ECB | AES_FLAGS_ENCRYPT); > @@ -1883,14 +1866,14 @@ static int atmel_aes_xts_start(struct atmel_aes_dev *dd) > ctx->key2, ctx->base.keylen); > dd->flags = flags; > > - atmel_aes_write_block(dd, AES_IDATAR(0), req->info); > + atmel_aes_write_block(dd, AES_IDATAR(0), (void *)req->iv); I think we can get rid of this explicit cast. And there are two checkpatch warnings introduced by this patch: WARNING: line over 80 characters #152: FILE: drivers/crypto/atmel-aes.c:999: + return atmel_aes_dma_start(dd, req->src, req->dst, req->cryptlen, WARNING: line over 80 characters #764: FILE: drivers/crypto/atmel-aes.c:1901: + return atmel_aes_dma_start(dd, req->src, req->dst, req->cryptlen, With these fixed one can add Reviewed-by: Tudor Ambarus <tudor.ambarus@xxxxxxxxxxxxx> Thanks again, Ard, ta
