On Thu, Nov 07, 2019 at 06:13:29PM -0800, Eric Biggers wrote: > On Wed, Nov 06, 2019 at 02:48:24PM +0100, David Sterba wrote: > > the patchset implements cleanups suggested by Eric in > > https://lore.kernel.org/linux-crypto/20191025051550.GA103313@sol.localdomain/ > > > > The diff is the same, split into pieces with some additional comments > > where it would help understand the simplifications. This is based on v7 > > of the BLAKE2b patchset. > > Actually the diff isn't quite the same. Your version looks fine though, except > that I think digest_setkey() should be renamed to blake2b_setkey(). Otherwise > it's inconsistent, since all the other digest_*() functions were renamed. Right, digest_* was a leftover from a working version. I'll send V2. Thanks for the review.