Re: [PATCH] crypto: ecdh - fix big endian bug in ECC library

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Oct 23, 2019 at 11:50:44AM +0200, Ard Biesheuvel wrote:
> The elliptic curve arithmetic library used by the EC-DH KPP implementation
> assumes big endian byte order, and unconditionally reverses the byte
> and word order of multi-limb quantities. On big endian systems, the byte
> reordering is not necessary, while the word ordering needs to be retained.
> 
> So replace the __swab64() invocation with a call to be64_to_cpu() which
> should do the right thing for both little and big endian builds.
> 
> Cc: <stable@xxxxxxxxxxxxxxx> # v4.9+
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@xxxxxxxxxx>
> ---
>  crypto/ecc.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt



[Index of Archives]     [Kernel]     [Gnu Classpath]     [Gnu Crypto]     [DM Crypt]     [Netfilter]     [Bugtraq]

  Powered by Linux