On Tue, Oct 22, 2019 at 05:14:13PM +0200, Arnd Bergmann wrote: > > case CONTEXT_CONTROL_CRYPTO_ALG_SM3: > if (safexcel_hmac_setkey("safexcel-sm3", keys.authkey, > - keys.authkeylen, &istate, &ostate)) > + keys.authkeylen, &state[0], &state[1])) > goto badkey; Any reason why this one remains as "goto badkey" instead of badkey_free? Thanks, -- Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt