On Tue, Oct 29, 2019 at 01:55:23AM +0000, YueHaibing wrote: > Use kmemdup rather than duplicating its implementation > > Signed-off-by: YueHaibing <yuehaibing@xxxxxxxxxx> > --- > drivers/crypto/amlogic/amlogic-gxl-cipher.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/crypto/amlogic/amlogic-gxl-cipher.c b/drivers/crypto/amlogic/amlogic-gxl-cipher.c > index e9283ffdbd23..78e776c58705 100644 > --- a/drivers/crypto/amlogic/amlogic-gxl-cipher.c > +++ b/drivers/crypto/amlogic/amlogic-gxl-cipher.c > @@ -372,10 +372,9 @@ int meson_aes_setkey(struct crypto_skcipher *tfm, const u8 *key, > kfree(op->key); > } > op->keylen = keylen; > - op->key = kmalloc(keylen, GFP_KERNEL | GFP_DMA); > + op->key = kmemdup(key, keylen, GFP_KERNEL | GFP_DMA); > if (!op->key) > return -ENOMEM; > - memcpy(op->key, key, keylen); > > return crypto_sync_skcipher_setkey(op->fallback_tfm, key, keylen); > } > > > Acked-by: Corentin Labbe <clabbe@xxxxxxxxxxxx> Thanks
