On Mon, 28 Oct 2019 at 11:36, Christophe Leroy <christophe.leroy@xxxxxx> wrote:
>
>
>
> Le 28/10/2019 à 07:20, Ard Biesheuvel a écrit :
> > On Sun, 27 Oct 2019 at 14:05, Christophe Leroy <christophe.leroy@xxxxxx> wrote:
> >>
> >>
> >>
> >> Le 27/10/2019 à 12:05, Ard Biesheuvel a écrit :
> >>> On Sun, 27 Oct 2019 at 11:45, Christophe Leroy <christophe.leroy@xxxxxx> wrote:
> >>>>
> >>>>
> >>>>
> >>>> Le 24/10/2019 à 15:23, Ard Biesheuvel a écrit :
> >>>>> Commit 7a7ffe65c8c5 ("crypto: skcipher - Add top-level skcipher interface")
> >>>>> dated 20 august 2015 introduced the new skcipher API which is supposed to
> >>>>> replace both blkcipher and ablkcipher. While all consumers of the API have
> >>>>> been converted long ago, some producers of the ablkcipher remain, forcing
> >>>>> us to keep the ablkcipher support routines alive, along with the matching
> >>>>> code to expose [a]blkciphers via the skcipher API.
> >>>>>
> >>>>> So switch this driver to the skcipher API, allowing us to finally drop the
> >>>>> blkcipher code in the near future.
> >>>>>
> >>>>> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@xxxxxxxxxx>
> >>>>
> >>>> With this series, I get the following Oops at boot:
> >>>>
> >>>
> >>> Thanks for the report.
> >>>
> >>> Given that the series only modifies ablkcipher implementations, it is
> >>> rather curious that the crash occurs in ahash_init(). Can you confirm
> >>> that the crash does not occur with this patch reverted?
> >>
> >> Yes I confirm.
> >>
> >> You changed talitos_cra_init_ahash(). talitos_init_common() is not
> >> called anymore. I think that's the reason.
> >>
> >
> > Thanks a lot for digging into this
> >
> > Does this fix things for you?
>
> Yes it does.
> Thanks.
> Christophe
>
Thanks a lot for confirming.
