Re: [PATCH v2 20/27] crypto: qce - switch to skcipher API

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Ard,

Thanks for the patch!

On 10/24/19 4:23 PM, Ard Biesheuvel wrote:
> Commit 7a7ffe65c8c5 ("crypto: skcipher - Add top-level skcipher interface")
> dated 20 august 2015 introduced the new skcipher API which is supposed to
> replace both blkcipher and ablkcipher. While all consumers of the API have
> been converted long ago, some producers of the ablkcipher remain, forcing
> us to keep the ablkcipher support routines alive, along with the matching
> code to expose [a]blkciphers via the skcipher API.
> 
> So switch this driver to the skcipher API, allowing us to finally drop the
> blkcipher code in the near future.
> 
> Cc: Stanimir Varbanov <stanimir.varbanov@xxxxxxxxxx>
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@xxxxxxxxxx>
> ---
>  drivers/crypto/qce/Makefile                     |   2 +-
>  drivers/crypto/qce/cipher.h                     |   8 +-
>  drivers/crypto/qce/common.c                     |  12 +-
>  drivers/crypto/qce/common.h                     |   3 +-
>  drivers/crypto/qce/core.c                       |   2 +-
>  drivers/crypto/qce/{ablkcipher.c => skcipher.c} | 172 ++++++++++----------
>  6 files changed, 100 insertions(+), 99 deletions(-)

Reviewed-by: Stanimir Varbanov <stanimir.varbanov@xxxxxxxxxx>

-- 
regards,
Stan



[Index of Archives]     [Kernel]     [Gnu Classpath]     [Gnu Crypto]     [DM Crypt]     [Netfilter]     [Bugtraq]

  Powered by Linux