On Wed, 23 Oct 2019 at 02:12, David Sterba <dsterba@xxxxxxxx> wrote: > > The patchset adds blake2b reference implementation and test vectors. > > V6: > > Patch 2/2: test vectors fixed to actually match the proposed table of > key and plaintext combinations. I shamelessly copied the test vector > value format that Ard uses for the blake2s test vectors. The array > blake2b_ordered_sequence can be shared between 2s and 2b but as the > patchsets go separate, unification would have to happen once both > are merged. > > Tested on x86_64 with KASAN and SLUB_DEBUG. > Tested-by: Ard Biesheuvel <ard.biesheuvel@xxxxxxxxxx> # arm64 big-endian > V1: https://lore.kernel.org/linux-crypto/cover.1569849051.git.dsterba@xxxxxxxx/ > V2: https://lore.kernel.org/linux-crypto/e31c2030fcfa7f409b2c81adf8f179a8a55a584a.1570184333.git.dsterba@xxxxxxxx/ > V3: https://lore.kernel.org/linux-crypto/e7f46def436c2c705c0b2cac3324f817efa4717d.1570715842.git.dsterba@xxxxxxxx/ > V4: https://lore.kernel.org/linux-crypto/cover.1570812094.git.dsterba@xxxxxxxx/ > V5: https://lore.kernel.org/linux-crypto/cover.1571043883.git.dsterba@xxxxxxxx/ > > David Sterba (2): > crypto: add blake2b generic implementation > crypto: add test vectors for blake2b > > crypto/Kconfig | 17 ++ > crypto/Makefile | 1 + > crypto/blake2b_generic.c | 413 +++++++++++++++++++++++++++++++++++++++ > crypto/testmgr.c | 28 +++ > crypto/testmgr.h | 307 +++++++++++++++++++++++++++++ > include/crypto/blake2b.h | 46 +++++ Final nit: do we need this header file at all? Could we move the contents into crypto/blake2b_generic.c? Or is the btrfs code going to #include it? > 6 files changed, 812 insertions(+) > create mode 100644 crypto/blake2b_generic.c > create mode 100644 include/crypto/blake2b.h > > -- > 2.23.0 >
