> -----Original Message----- > From: Arnd Bergmann <arnd@xxxxxxxx> > Sent: Tuesday, October 22, 2019 6:17 PM > To: Pascal Van Leeuwen <pvanleeuwen@xxxxxxxxxxxxxx> > Cc: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>; David S. Miller <davem@xxxxxxxxxxxxx>; Antoine > Tenart <antoine.tenart@xxxxxxxxxxx>; Ard Biesheuvel <ard.biesheuvel@xxxxxxxxxx>; Pascal van > Leeuwen <pascalvanl@xxxxxxxxx>; linux-crypto@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx > Subject: Re: [PATCH] crypto: inside-secure - select CONFIG_CRYPTO_SM3 > > On Tue, Oct 22, 2019 at 5:42 PM Pascal Van Leeuwen > <pvanleeuwen@xxxxxxxxxxxxxx> wrote: > > > > diff --git a/drivers/crypto/Kconfig b/drivers/crypto/Kconfig > > > index 357e230769c8..1ca8d9a15f2a 100644 > > > --- a/drivers/crypto/Kconfig > > > +++ b/drivers/crypto/Kconfig > > > @@ -753,6 +753,7 @@ config CRYPTO_DEV_SAFEXCEL > > > select CRYPTO_SHA512 > > > select CRYPTO_CHACHA20POLY1305 > > > select CRYPTO_SHA3 > > > + select CRYPTO_SM3 > > > > > Was this problem observed with the latest state of the Cryptodev GIT? > > Because I already attempted to fix this issue with commit 99a59da3723b9725 > > Can you please double check if you still get the compile error with that > > commit included? > > (I can't tell from this mail which version of the sources you are using) > > I was testing on linux-5.4-rc3 plus some of my own patches, so your fix > was not included. > > With your patch applied, mine is no longer needed. > > Arnd Thanks for confirming that :-) Regards, Pascal van Leeuwen Silicon IP Architect, Multi-Protocol Engines @ Verimatrix www.insidesecure.com