On Mon, 21 Oct 2019 at 12:05, Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote:
>
> On Mon, Oct 14, 2019 at 02:18:52PM +0200, Ard Biesheuvel wrote:
> > Commit 7a7ffe65c8c5 ("crypto: skcipher - Add top-level skcipher interface")
> > dated 20 august 2015 introduced the new skcipher API which is supposed to
> > replace both blkcipher and ablkcipher. While all consumers of the API have
> > been converted long ago, some producers of the ablkcipher remain, forcing
> > us to keep the ablkcipher support routines alive, along with the matching
> > code to expose [a]blkciphers via the skcipher API.
> >
> > So switch this driver to the skcipher API, allowing us to finally drop the
> > blkcipher code in the near future.
> >
> > Cc: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
> > Cc: Vladimir Zapolskiy <vz@xxxxxxxxx>
> > Cc: Kamil Konieczny <k.konieczny@xxxxxxxxxxxxxxxxxxx>
> > Cc: linux-samsung-soc@xxxxxxxxxxxxxxx
> > Signed-off-by: Ard Biesheuvel <ard.biesheuvel@xxxxxxxxxx>
> > ---
> > drivers/crypto/s5p-sss.c | 191 ++++++++++----------
> > 1 file changed, 91 insertions(+), 100 deletions(-)
> >
> > diff --git a/drivers/crypto/s5p-sss.c b/drivers/crypto/s5p-sss.c
> > index 010f1bb20dad..e6f1d4d5186c 100644
> > --- a/drivers/crypto/s5p-sss.c
> > +++ b/drivers/crypto/s5p-sss.c
> > @@ -303,7 +303,7 @@ struct s5p_aes_dev {
> > void __iomem *aes_ioaddr;
> > int irq_fc;
> >
> > - struct ablkcipher_request *req;
> > + struct skcipher_request *req;
>
> You mix here indentation.
>
Will fix
> Beside that:
>
> Acked-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
>
Thanks!
