Re: [PATCH] crypto: arm - use Kconfig based compiler checks for crypto opcodes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Oct 11, 2019 at 11:08:00AM +0200, Ard Biesheuvel wrote:
> Instead of allowing the Crypto Extensions algorithms to be selected when
> using a toolchain that does not support them, and complain about it at
> build time, use the information we have about the compiler to prevent
> them from being selected in the first place. Users that are stuck with
> a GCC version <4.8 are unlikely to care about these routines anyway, and
> it cleans up the Makefile considerably.
> 
> While at it, add explicit 'armv8-a' CPU specifiers to the code that uses
> the 'crypto-neon-fp-armv8' FPU specifier so we don't regress Clang, which
> will complain about this in version 10 and later.
> 
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@xxxxxxxxxx>
> ---
>  arch/arm/crypto/Kconfig             | 14 +++++++------
>  arch/arm/crypto/Makefile            | 32 ++++++-----------------------
>  arch/arm/crypto/aes-ce-core.S       |  1 +
>  arch/arm/crypto/crct10dif-ce-core.S |  2 +-
>  arch/arm/crypto/ghash-ce-core.S     |  1 +
>  arch/arm/crypto/sha1-ce-core.S      |  1 +
>  arch/arm/crypto/sha2-ce-core.S      |  1 +
>  7 files changed, 19 insertions(+), 33 deletions(-)

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt



[Index of Archives]     [Kernel]     [Gnu Classpath]     [Gnu Crypto]     [DM Crypt]     [Netfilter]     [Bugtraq]

  Powered by Linux