On Wed, Oct 16, 2019 at 09:12:30AM +0200, Borislav Petkov wrote: > Hi, > > On Fri, Oct 11, 2019 at 01:51:04PM +0200, Jiri Slaby wrote: > > These are all functions which are invoked from elsewhere, so annotate > > them as global using the new SYM_FUNC_START. And their ENDPROC's by > > SYM_FUNC_END. > > > > And make sure ENTRY/ENDPROC is not defined on X86_64, given these were > > the last users. > > > > Signed-off-by: Jiri Slaby <jslaby@xxxxxxx> > > Reviewed-by: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx> [hibernate] > > Reviewed-by: Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx> [xen bits] > > Cc: "H. Peter Anvin" <hpa@xxxxxxxxx> > > Cc: Borislav Petkov <bp@xxxxxxxxx> > > Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx> > > Cc: Ingo Molnar <mingo@xxxxxxxxxx> > > Cc: x86@xxxxxxxxxx > > Cc: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> > > Cc: "David S. Miller" <davem@xxxxxxxxxxxxx> > > Cc: "Rafael J. Wysocki" <rjw@xxxxxxxxxxxxx> > > Cc: Len Brown <len.brown@xxxxxxxxx> > > Cc: Pavel Machek <pavel@xxxxxx> > > Cc: Matt Fleming <matt@xxxxxxxxxxxxxxxxxxx> > > Cc: Ard Biesheuvel <ard.biesheuvel@xxxxxxxxxx> > > Cc: Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx> > > Cc: Juergen Gross <jgross@xxxxxxxx> > > Cc: linux-crypto@xxxxxxxxxxxxxxx > > Cc: linux-pm@xxxxxxxxxxxxxxx > > Cc: linux-efi@xxxxxxxxxxxxxxx > > Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx > > --- > > arch/x86/boot/compressed/efi_thunk_64.S | 4 +- > > arch/x86/boot/compressed/head_64.S | 16 +++--- > > arch/x86/boot/compressed/mem_encrypt.S | 8 +-- > > arch/x86/crypto/aegis128-aesni-asm.S | 28 ++++----- > > arch/x86/crypto/aes_ctrby8_avx-x86_64.S | 12 ++-- > > arch/x86/crypto/aesni-intel_asm.S | 60 ++++++++++---------- > > arch/x86/crypto/aesni-intel_avx-x86_64.S | 32 +++++------ > > arch/x86/crypto/blowfish-x86_64-asm_64.S | 16 +++--- > > arch/x86/crypto/camellia-aesni-avx-asm_64.S | 24 ++++---- > > arch/x86/crypto/camellia-aesni-avx2-asm_64.S | 24 ++++---- > > arch/x86/crypto/camellia-x86_64-asm_64.S | 16 +++--- > > arch/x86/crypto/cast5-avx-x86_64-asm_64.S | 16 +++--- > > arch/x86/crypto/cast6-avx-x86_64-asm_64.S | 24 ++++---- > > arch/x86/crypto/chacha-avx2-x86_64.S | 12 ++-- > > arch/x86/crypto/chacha-avx512vl-x86_64.S | 12 ++-- > > arch/x86/crypto/chacha-ssse3-x86_64.S | 12 ++-- > > arch/x86/crypto/crc32-pclmul_asm.S | 4 +- > > arch/x86/crypto/crc32c-pcl-intel-asm_64.S | 4 +- > > arch/x86/crypto/crct10dif-pcl-asm_64.S | 4 +- > > arch/x86/crypto/des3_ede-asm_64.S | 8 +-- > > arch/x86/crypto/ghash-clmulni-intel_asm.S | 8 +-- > > arch/x86/crypto/nh-avx2-x86_64.S | 4 +- > > arch/x86/crypto/nh-sse2-x86_64.S | 4 +- > > arch/x86/crypto/poly1305-avx2-x86_64.S | 4 +- > > arch/x86/crypto/poly1305-sse2-x86_64.S | 8 +-- > > arch/x86/crypto/serpent-avx-x86_64-asm_64.S | 24 ++++---- > > arch/x86/crypto/serpent-avx2-asm_64.S | 24 ++++---- > > arch/x86/crypto/serpent-sse2-x86_64-asm_64.S | 8 +-- > > arch/x86/crypto/sha1_avx2_x86_64_asm.S | 4 +- > > arch/x86/crypto/sha1_ni_asm.S | 4 +- > > arch/x86/crypto/sha1_ssse3_asm.S | 4 +- > > arch/x86/crypto/sha256-avx-asm.S | 4 +- > > arch/x86/crypto/sha256-avx2-asm.S | 4 +- > > arch/x86/crypto/sha256-ssse3-asm.S | 4 +- > > arch/x86/crypto/sha256_ni_asm.S | 4 +- > > arch/x86/crypto/sha512-avx-asm.S | 4 +- > > arch/x86/crypto/sha512-avx2-asm.S | 4 +- > > arch/x86/crypto/sha512-ssse3-asm.S | 4 +- > > arch/x86/crypto/twofish-avx-x86_64-asm_64.S | 24 ++++---- > > arch/x86/crypto/twofish-x86_64-asm_64-3way.S | 8 +-- > > arch/x86/crypto/twofish-x86_64-asm_64.S | 8 +-- > > I could use an ACK for the crypto bits... Acked-by: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Cheers, -- Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
