> -----Original Message----- > From: linux-crypto-owner@xxxxxxxxxxxxxxx <linux-crypto-owner@xxxxxxxxxxxxxxx> On Behalf Of > Randy Dunlap > Sent: Wednesday, October 9, 2019 5:50 PM > To: LKML <linux-kernel@xxxxxxxxxxxxxxx>; Linux Crypto Mailing List <linux- > crypto@xxxxxxxxxxxxxxx> > Cc: Antoine Tenart <antoine.tenart@xxxxxxxxxxxxxxxxxx>; Herbert Xu > <herbert@xxxxxxxxxxxxxxxxxxx>; David Miller <davem@xxxxxxxxxxxxx> > Subject: [PATCH -next] crypto: inside-secure: fix build error for safexcel_hash.c > > From: Randy Dunlap <rdunlap@xxxxxxxxxxxxx> > > safexcel_hash.c (CRYPTO_DEV_SAFEXCEL) needs to select CRYPTO_SM3. > > Fixes this build error: > > safexcel_hash.c:(.text+0x1b17): undefined reference to `sm3_zero_message_hash' > > Fixes: 1b44c5a60c13 ("crypto: inside-secure - add SafeXcel EIP197 crypto engine driver") > Signed-off-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx> > Cc: Antoine Tenart <antoine.tenart@xxxxxxxxxxxxxxxxxx> > Cc: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> > Cc: "David S. Miller" <davem@xxxxxxxxxxxxx> > Cc: linux-crypto@xxxxxxxxxxxxxxx > --- > drivers/crypto/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > --- linux-next-20191009.orig/drivers/crypto/Kconfig > +++ linux-next-20191009/drivers/crypto/Kconfig > @@ -751,6 +751,7 @@ config CRYPTO_DEV_SAFEXCEL > select CRYPTO_SHA512 > select CRYPTO_CHACHA20POLY1305 > select CRYPTO_SHA3 > + select CRYPTO_SM3 > help > This driver interfaces with the SafeXcel EIP-97 and EIP-197 cryptographic > engines designed by Inside Secure. It currently accelerates DES, 3DES and > I'm spinning a patch to fix this without having to actually build in the SM3 module. So NACK on this patch. Regards, Pascal van Leeuwen Silicon IP Architect, Multi-Protocol Engines @ Verimatrix www.insidesecure.com