On Tue, Oct 15, 2019 at 09:16:57AM -0700, Davidlohr Bueso wrote: > Because it is not a Rmw operation, atomic_set() is not serialized, > and therefore the 'upgradable' smp_mb__after_atomic() call after > the atomic_set() is completely bogus (not to mention the comment > could also use some love, but that's a different matter). > > This patch replaces these with smp_mb(), which seems like the > original intent of when the code was written. > > Signed-off-by: Davidlohr Bueso <dbueso@xxxxxxx> > --- > drivers/crypto/cavium/nitrox/nitrox_main.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) So what does this actually synchronise against? Cheers, -- Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
