Hi, Ard,
Thanks for working on this.
On 10/14/2019 03:18 PM, Ard Biesheuvel wrote:
> Commit 7a7ffe65c8c5 ("crypto: skcipher - Add top-level skcipher interface")
> dated 20 august 2015 introduced the new skcipher API which is supposed to
> replace both blkcipher and ablkcipher. While all consumers of the API have
> been converted long ago, some producers of the ablkcipher remain, forcing
> us to keep the ablkcipher support routines alive, along with the matching
> code to expose [a]blkciphers via the skcipher API.
>
> So switch this driver to the skcipher API, allowing us to finally drop the
> blkcipher code in the near future.
>
> Cc: Nicolas Ferre <nicolas.ferre@xxxxxxxxxxxxx>
> Cc: Alexandre Belloni <alexandre.belloni@xxxxxxxxxxx>
> Cc: Ludovic Desroches <ludovic.desroches@xxxxxxxxxxxxx>
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@xxxxxxxxxx>
> ---
> drivers/crypto/atmel-aes.c | 507 ++++++++++----------
> 1 file changed, 244 insertions(+), 263 deletions(-)
drivers/crypto/atmel-aes.c: In function ‘atmel_aes_register_algs’:
drivers/crypto/atmel-aes.c:2515:24: error: passing argument 1 of ‘crypto_unregister_alg’ from incompatible pointer type [-Werror=incompatible-pointer-types]
crypto_unregister_alg(&aes_xts_alg);
^
In file included from drivers/crypto/atmel-aes.c:32:0:
./include/linux/crypto.h:703:5: note: expected ‘struct crypto_alg *’ but argument is of type ‘struct skcipher_alg *’
int crypto_unregister_alg(struct crypto_alg *alg);
^~~~~~~~~~~~~~~~~~~~~
and when applying tdes:
Applying: crypto: atmel-tdes - switch to skcipher API
.git/rebase-apply/patch:637: trailing whitespace.
warning: 1 line adds whitespace errors.
I'll try to review the atmel part next week.
Cheers,
ta
