On Sun, 13 Oct 2019 at 08:29, Ard Biesheuvel <ard.biesheuvel@xxxxxxxxxx> wrote: > > On Sun, 13 Oct 2019 at 06:40, Eric Biggers <ebiggers@xxxxxxxxxx> wrote: > > > > This series converts the PowerPC Nest (NX) implementations of AES modes > > from the deprecated "blkcipher" API to the "skcipher" API. This is > > needed in order for the blkcipher API to be removed. > > > > This patchset is compile-tested only, as I don't have this hardware. > > If anyone has this hardware, please test this patchset with > > CONFIG_CRYPTO_MANAGER_EXTRA_TESTS=y. > > > > Eric Biggers (4): > > crypto: nx - don't abuse blkcipher_desc to pass iv around > > crypto: nx - convert AES-ECB to skcipher API > > crypto: nx - convert AES-CBC to skcipher API > > crypto: nx - convert AES-CTR to skcipher API > > > > drivers/crypto/nx/nx-aes-cbc.c | 81 ++++++++++++++----------------- > > drivers/crypto/nx/nx-aes-ccm.c | 40 ++++++---------- > > drivers/crypto/nx/nx-aes-ctr.c | 87 +++++++++++++++------------------- > > drivers/crypto/nx/nx-aes-ecb.c | 76 +++++++++++++---------------- > > drivers/crypto/nx/nx-aes-gcm.c | 24 ++++------ > > drivers/crypto/nx/nx.c | 64 ++++++++++++++----------- > > drivers/crypto/nx/nx.h | 19 ++++---- > > 7 files changed, 176 insertions(+), 215 deletions(-) > > > > Hi Eric, > > Thanks for taking this on. I'll look in more detail at these patches > during the week. In the meantime, I may have a stab at converting ccp, > virtio-crypto and omap aes/des myself, since i have the hardware to > test those. > OK, I got a bit carried away, and converted a bunch of platforms in drivers/crypto (build tested only, except for the virtio driver) crypto: qce - switch to skcipher API crypto: rockchip - switch to skcipher API crypto: stm32 - switch to skcipher API crypto: sahara - switch to skcipher API crypto: picoxcell - switch to skcipher API crypto: mediatek - switch to skcipher API crypto: mxs - switch to skcipher API crypto: ixp4xx - switch to skcipher API crypto: hifn - switch to skcipher API crypto: chelsio - switch to skcipher API crypto: cavium/cpt - switch to skcipher API crypto: nitrox - remove cra_type reference to ablkcipher crypto: bcm-spu - switch to skcipher API crypto: atmel-tdes - switch to skcipher API crypto: atmel-aes - switch to skcipher API crypto: s5p - switch to skcipher API crypto: ux500 - switch to skcipher API crypto: omap - switch to skcipher API crypto: virtio - switch to skcipher API crypto: virtio - deal with unsupported input sizes crypto: virtio - implement missing support for output IVs crypto: ccp - switch from ablkcipher to skcipher https://git.kernel.org/pub/scm/linux/kernel/git/ardb/linux.git/log/?h=ablkcipher-removal I pushed the branch to kernelci, so hopefully we'll get some automated results, but I think only a small subset of these are boot tested atm.