[PATCH v4 0/5] BLAKE2b generic implementation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



The patchset adds blake2b refrerence implementation and test vectors.

V4:

Code changes:

- removed .finup
- removed .cra_init
- dropped redundant sanity checks (key length, output size length)
- switch blake2b_param from a 1 element array to plain struct
- direct assignment in blake2b_init, instead of put_unaligned*
- removed blake2b_is_lastblock
- removed useless error cases in the blake * helpers
- replace digest_desc_ctx with blake2b_state
- use __le32 in blake2b_param

Added testmgr vectors:

- all digests covered: 160, 256, 384, 512
- 4 different keys:
  - empty
  - short (1 byte, 'B', 0x42)
  - half of the default key (32 bytes, sequence 00..1f)
  - default key (64 bytes, sequence 00..3f)
- plaintext values:
  - subsequences of 0..15 and 247..255
  - the full range 0..255 add up to 4MiB of .h, for all digests and key
    sizes, so this is not very practical for the in-kernel testsuite
- official blake2 provided test vectors are only for empty and default key for
  digest size 512
- the remaining combinations were obtained from b2sum utility (enhanced to
  accept a key)

Testing performed:

- compiled with SLUB_DEBUG and KASAN, plus crypto selftests
  CONFIG_CRYPTO_MANAGER2=y
  CONFIG_CRYPTO_MANAGER_DISABLE_TESTS=n
  CONFIG_CRYPTO_MANAGER_EXTRA_TESTS=y
- module loaded, no errors reported from the tessuite
- (un)intentionally broken test values were detected

The test values were produced by b2sum, compiled from the reference
implementation. The generated values were cross-checked by pyblake2
based script (ie. not the same sources, built by distro).

The .h portion of testmgr is completely generated, so in case somebody feels
like reducing it in size, adding more keys, changing the formatting, it's easy
to do.

In case the patches don't make it to the mailinglist, it's in git

  git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux.git dev/blake2b-v4

V1: https://lore.kernel.org/linux-crypto/cover.1569849051.git.dsterba@xxxxxxxx/
V2: https://lore.kernel.org/linux-crypto/e31c2030fcfa7f409b2c81adf8f179a8a55a584a.1570184333.git.dsterba@xxxxxxxx/
V3: https://lore.kernel.org/linux-crypto/e7f46def436c2c705c0b2cac3324f817efa4717d.1570715842.git.dsterba@xxxxxxxx/

David Sterba (5):
  crypto: add blake2b generic implementation
  crypto: add test vectors for blake2b-160
  crypto: add test vectors for blake2b-256
  crypto: add test vectors for blake2b-384
  crypto: add test vectors for blake2b-512

 crypto/Kconfig           |    17 +
 crypto/Makefile          |     1 +
 crypto/blake2b_generic.c |   418 ++
 crypto/testmgr.c         |    28 +
 crypto/testmgr.h         | 10561 +++++++++++++++++++++++++++++++++++++
 include/crypto/blake2b.h |    48 +
 6 files changed, 11073 insertions(+)
 create mode 100644 crypto/blake2b_generic.c
 create mode 100644 include/crypto/blake2b.h

-- 
2.23.0




[Index of Archives]     [Kernel]     [Gnu Classpath]     [Gnu Crypto]     [DM Crypt]     [Netfilter]     [Bugtraq]

  Powered by Linux