Re: [PATCH v2 01/20] crypto: chacha - move existing library code into lib/crypto

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Oct 02, 2019 at 04:16:54PM +0200, Ard Biesheuvel wrote:
> Move the existing shared ChaCha code into lib/crypto, and at the
> same time, split the support header into a public version, and an
> internal version that is only intended for consumption by crypto
> implementations.
> 
> At the same time, refactor the generic implementation so it only gets
> exposed as the chacha_crypt() library function if the architecture does
> not override it with its own implementation, potentially falling back
> to the generic routine if needed.

That's a _lot_ to do all in one patch.

And you are saying _what_ you are doing, but not _why_.

Why move all this around and do these changes?  What's wrong with the
code as-is in the current location?  Is all of the crc and other
"crypto" code going to be moved into lib/crypto/ as well?

thanks,

greg k-h



[Index of Archives]     [Kernel]     [Gnu Classpath]     [Gnu Crypto]     [DM Crypt]     [Netfilter]     [Bugtraq]

  Powered by Linux