On Fri, Sep 13, 2019 at 11:04:40AM +0200, Pascal van Leeuwen wrote: > This patch fixes an unused variable warning from the compiler when the > driver is being compiled without PCI support in the kernel. > > changes since v1: > - capture the platform_register_driver error code as well > - actually return the (last) error code > - swapped registration to do PCI first as that's just for development > boards anyway, so in case both are done we want the platform error > or no error at all if that passes > - also fixes some indentation issue in the affected code > > changes since v2: > - handle the situation where both CONFIG_PCI and CONFIG_OF are undefined > by always returning a -EINVAL error > - only unregister PCI or OF if it was previously successfully registered > > changes since v3: > - if *both* PCI and OF are configured, then return success if *either* > registration was OK, also ensuring exit is called and PCI unregister > occurs (eventually) if only OF registration fails > > Signed-off-by: Pascal van Leeuwen <pvanleeuwen@xxxxxxxxxxxxxx> > --- > drivers/crypto/inside-secure/safexcel.c | 40 ++++++++++++++++++++++++--------- > 1 file changed, 29 insertions(+), 11 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
