On Thu, Sep 19, 2019 at 04:11:13PM +0800, Zhou Wang wrote: > On 2019/9/13 17:17, Herbert Xu wrote: > > On Fri, Sep 06, 2019 at 05:22:30PM +0200, Arnd Bergmann wrote: > >> The only caller of hisi_zip_vf_q_assign() is hidden in an #ifdef, > >> so the function causes a warning when CONFIG_PCI_IOV is disabled: > >> > >> drivers/crypto/hisilicon/zip/zip_main.c:740:12: error: unused function 'hisi_zip_vf_q_assign' [-Werror,-Wunused-function] > >> > >> Move it into the same #ifdef. > >> > >> Fixes: 79e09f30eeba ("crypto: hisilicon - add SRIOV support for ZIP") > >> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx> > >> --- > >> drivers/crypto/hisilicon/zip/zip_main.c | 2 ++ > >> 1 file changed, 2 insertions(+) > > > > Please find a way to fix this warning without reducing compiler > > coverage. I prefer to see any compile issues immediately rather > > than through automated build testing. > > > > Thanks, > > > > Sorry for missing this patch. > > Seems other drivers also do like using #ifdef. Do you mean something like this: > #ifdef CONFIG_PCI_IOV > sriov_enable() > ... > #else > /* stub */ > sriov_enable() > ... > #endif For an unused warning the unused compiler attribute would seem to be the way to go. Cheers, -- Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt