On Thu, Sep 19, 2019 at 07:36:20AM +0200, Steffen Klassert wrote: > On Wed, Sep 18, 2019 at 10:15:45PM -0700, Eric Biggers wrote: > > > > Reproducer involves pcrypt, so probably the pcrypt deadlock again... > > https://lkml.kernel.org/linux-crypto/20190817054743.GE8209@sol.localdomain/ > > I'll submit the patch I proposed here in case noone has a better idea > how to fix this now: > > https://lkml.kernel.org/linux-crypto/20190821063704.GM2879@xxxxxxxxxxxxxxxxx/ > > The original patch is from you, I did some modifications to forbid > pcrypt if an underlying algorithm needs a fallback. > > May I leave your 'Signed off' on this patch, or just > quote that the initial version is from you? > Keeping my Signed-off-by is fine, but please leave a note about what you changed, like: Signed-off-by: Eric Biggers <ebiggers@xxxxxxxxxx> [SK: also require that the underlying algorithm doesn't need a fallback] Signed-off-by: Steffen Klassert <steffen.klassert@xxxxxxxxxxx> Also, a nit: in the commit message, > Fix this by making pcrypt forbid instantiation if pcrypt appears in the > underlying ->cra_driver_name and if an underlying algorithm needs a > fallback. ... the word "and" should be "or". - Eric
