> -----Original Message----- > From: Ard Biesheuvel <ard.biesheuvel@xxxxxxxxxx> > Sent: Friday, September 13, 2019 6:24 PM > To: Pascal Van Leeuwen <pvanleeuwen@xxxxxxxxxxxxxx> > Cc: Pascal van Leeuwen <pascalvanl@xxxxxxxxx>; open list:HARDWARE RANDOM NUMBER > GENERATOR CORE <linux-crypto@xxxxxxxxxxxxxxx>; Antoine Tenart > <antoine.tenart@xxxxxxxxxxx>; Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>; David S. Miller > <davem@xxxxxxxxxxxxx> > Subject: Re: [PATCH 1/3] crypto: inside-secure - Added support for authenc HMAC- > SHA1/DES-CBC > > On Fri, 13 Sep 2019 at 17:17, Pascal Van Leeuwen > <pvanleeuwen@xxxxxxxxxxxxxx> wrote: > > > > > -----Original Message----- > > > From: Ard Biesheuvel <ard.biesheuvel@xxxxxxxxxx> > > > Sent: Friday, September 13, 2019 5:27 PM > > > To: Pascal van Leeuwen <pascalvanl@xxxxxxxxx> > > > Cc: open list:HARDWARE RANDOM NUMBER GENERATOR CORE <linux-crypto@xxxxxxxxxxxxxxx>; > > > Antoine Tenart <antoine.tenart@xxxxxxxxxxx>; Herbert Xu > <herbert@xxxxxxxxxxxxxxxxxxx>; > > > David S. Miller <davem@xxxxxxxxxxxxx>; Pascal Van Leeuwen > <pvanleeuwen@xxxxxxxxxxxxxx> > > > Subject: Re: [PATCH 1/3] crypto: inside-secure - Added support for authenc HMAC- > > > SHA1/DES-CBC > > > > > > On Fri, 13 Sep 2019 at 16:06, Pascal van Leeuwen <pascalvanl@xxxxxxxxx> wrote: > > > > > > > > This patch adds support for the authenc(hmac(sha1),cbc(des)) aead > > > > > > > > Signed-off-by: Pascal van Leeuwen <pvanleeuwen@xxxxxxxxxxxxxx> > > > > > > Please make sure your code is based on cryptodev/master before sending > > > it to the list. > > > > > Looks like with this patchset and the previous (SHA3) patchset I forgot > > to add the disclaimer that it applies on top of the previous patchset. > > Mea culpa. > > > > So there you go: "Added support for authenc HMAC-SHA1/DES-CBC" applies > > on top of "Added (HMAC) SHA3 support", which applies on top of > > "Add support for SM4 ciphers". > > > > Sorry if I wasn't clear, but that was not my point. > > You should really base your code on cryptodev/master since some of the > DES helpers you are using don't exist anymore. > Ah, ok, I'll look into that ... I don't always notice that something changed in cryptodev/master. Which doesn't happen too frequently, so it's easy to miss. One of the downsides of Git compared to "normal" version control systems: you have to manually keep track of master. Regards, Pascal van Leeuwen Silicon IP Architect, Multi-Protocol Engines @ Verimatrix www.insidesecure.com
