Hi Corentin, On Wed, Sep 11, 2019 at 08:31:58PM +0200, Corentin Labbe wrote: > On Sat, Sep 07, 2019 at 07:01:16AM +0300, Maxime Ripard wrote: > > On Fri, Sep 06, 2019 at 08:45:45PM +0200, Corentin Labbe wrote: > > > This patch adds documentation for Device-Tree bindings for the > > > Crypto Engine cryptographic accelerator driver. > > > > > > Signed-off-by: Corentin Labbe <clabbe.montjoie@xxxxxxxxx> > > > --- > > > .../bindings/crypto/allwinner,sun8i-ce.yaml | 84 +++++++++++++++++++ > > > 1 file changed, 84 insertions(+) > > > create mode 100644 Documentation/devicetree/bindings/crypto/allwinner,sun8i-ce.yaml > > > > > > diff --git a/Documentation/devicetree/bindings/crypto/allwinner,sun8i-ce.yaml b/Documentation/devicetree/bindings/crypto/allwinner,sun8i-ce.yaml > [...] > > > +else: > > > + clocks: > > > + items: > > > + - description: Bus clock > > > + - description: Module clock > > > + > > > + clock-names: > > > + items: > > > + - const: ahb > > > + - const: mod > > > + > > > + resets: > > > + maxItems: 1 > > > + > > > + reset-names: > > > + const: ahb > > > > This prevents the usage of the additionalProperties property, which > > you should really use. > > > > What you can do instead is moving the clocks and clock-names > > description under properties, with a minItems of 2 and a maxItems of > > 3. Then you can restrict the length of that property to either 2 or 3 > > depending on the case here. > > > > Hello > > I fail to do this. > I do the following (keeped only clock stuff) > properties: > > clocks: > items: > - description: Bus clock > - description: Module clock > - description: MBus clock Add minItems: 2 and maxItems: 3 at the same level than items > > clock-names: > items: > - const: ahb > - const: mod > - const: mbus And here as well Something I missed earlier though was that we've tried to unify as much as possible the ahb / apb / axi clocks around the bus name, it would be great if you could do it. > > if: > properties: > compatible: > items: > const: allwinner,sun50i-h6-crypto > then: > properties: > clocks: > minItems: 3 > maxItems: 3 > clock-names: > minItems: 3 > maxItems: 3 You don't need to duplicate the min and maxItems here Maxime
Attachment:
signature.asc
Description: PGP signature
