Hi Pascal,
On Wed, Sep 11, 2019 at 09:41:09AM +0200, Pascal van Leeuwen wrote:
> static int safexcel_register_algorithms(struct safexcel_crypto_priv *priv)
> diff --git a/drivers/crypto/inside-secure/safexcel.h b/drivers/crypto/inside-secure/safexcel.h
> index 282d59e..fc2aba2 100644
> --- a/drivers/crypto/inside-secure/safexcel.h
> +++ b/drivers/crypto/inside-secure/safexcel.h
> @@ -374,6 +374,7 @@ struct safexcel_context_record {
> #define CONTEXT_CONTROL_CRYPTO_ALG_XCBC192 (0x2 << 23)
> #define CONTEXT_CONTROL_CRYPTO_ALG_XCBC256 (0x3 << 23)
> #define CONTEXT_CONTROL_CRYPTO_ALG_POLY1305 (0xf << 23)
> +#define CONTEXT_CONTROL_CRYPTO_ALG_SM3 (0x7 << 23)
Please order the definitions (0x7 before 0xf).
Otherwise the patch looks good, and with that you can add:
Acked-by: Antoine Tenart <antoine.tenart@xxxxxxxxxxx>
Thanks!
Antoine
--
Antoine Ténart, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
