On Wed, Aug 28, 2019 at 04:07:40PM +0800, Mao Wenan wrote: > When CRYPTO_DEV_HISI_SEC=y, below compilation error is found after > 'commit 894b68d8be4b ("crypto: hisilicon/des - switch to new verification routines")': > > drivers/crypto/hisilicon/sec/sec_algs.o: In function `sec_alg_skcipher_setkey_des_cbc': > sec_algs.c:(.text+0x11f0): undefined reference to `des_expand_key' > drivers/crypto/hisilicon/sec/sec_algs.o: In function `sec_alg_skcipher_setkey_des_ecb': > sec_algs.c:(.text+0x1390): undefined reference to `des_expand_key' > make: *** [vmlinux] Error 1 > > This because DES library has been moved to lib/crypto in this commit > '04007b0e6cbb ("crypto: des - split off DES library from generic DES cipher driver")'. > Fix this by selecting CRYPTO_LIB_DES in CRYPTO_DEV_HISI_SEC. > > Fixes: 04007b0e6cbb ("crypto: des - split off DES library from generic DES cipher driver") > Fixes: 894b68d8be4b ("crypto: hisilicon/des - switch to new verification routines") > > Signed-off-by: Mao Wenan <maowenan@xxxxxxxxxx> > Acked-by: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx> > --- > v2: remove fix tag 915e4e8413da ("crypto: hisilicon - SEC security accelerator driver") > drivers/crypto/hisilicon/Kconfig | 1 + > 1 file changed, 1 insertion(+) Patch applied. Thanks. -- Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt